Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement query spo-stake-distribution #854

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Implement query spo-stake-distribution #854

merged 1 commit into from
Aug 15, 2024

Conversation

palas
Copy link
Contributor

@palas palas commented Jul 31, 2024 •
edited by carbolymer
Loading

Changelog

- description: |
    Add `query spo-stake-distribution` command to obtain stake distribution for SPOs
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature

Context

This PR solves this issue: #850

It currently requires a source stanza sinze it requires on new functionality in cardano-api introduced in this PR: IntersectMBO/cardano-api#598

DO NOT MERGE: The PR shouldn't be merged before the stanza is not required and removed.

Associated PRs:

How to trust this PR

You can check the test in IntersectMBO/cardano-node#5932. I would ensure that documentation is consistent and sensible, and the types for keys are correct.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added enhancement New feature or request DO NOT MERGE labels Jul 31, 2024
@palas palas self-assigned this Jul 31, 2024
@palas palas linked an issue Jul 31, 2024 that may be closed by this pull request
[FR] - Provide governance query for stake distribution #850
Closed
This was referenced Jul 31, 2024
Merged
Merged
@carbolymer carbolymer requested review from a team as code owners August 15, 2024 06:52
@carbolymer carbolymer added this pull request to the merge queue Aug 15, 2024
Merged via the queue into main with commit abe9d0f Aug 15, 2024
25 checks passed
@carbolymer carbolymer deleted the query-spo-stake-distr branch August 15, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@smelc smelc Awaiting requested review from smelc smelc is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

@palas palas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - Provide governance query for stake distribution
2 participants
@palas @carbolymer