-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
governance: add hash command and remove text/file hash arguments of existing commands #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
force-pushed
the
smelc/governance-rework-hash-arguments
branch
7 times, most recently
from
November 9, 2023 10:36
cc0b1a7
to
9fe6ea3
Compare
Jimbo4350
previously requested changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still disagree with this naming because it is ambiguous.
hashAnchorData :: forall c. Crypto c => AnchorData -> SafeHash c AnchorData
hashAnchorData = hashWithCrypto (Proxy @c)
data Anchor c = Anchor
{ anchorUrl :: !Url
, anchorDataHash :: !(SafeHash c AnchorData)
}
deriving (Eq, Ord, Show, Generic)
This is not the hash of the Anchor. It is the hash of the Anchor's metadata. I think people will wrongly assume the URL is also hashed. We can reduce metadata
to data
or come up with something else.
smelc
force-pushed
the
smelc/governance-rework-hash-arguments
branch
from
November 9, 2023 14:50
9fe6ea3
to
0cb397b
Compare
8 tasks
smelc
force-pushed
the
smelc/governance-rework-hash-arguments
branch
3 times, most recently
from
November 10, 2023 10:52
da9eda4
to
1ab7d09
Compare
smelc
requested review from
newhoggy,
carbolymer,
kevinhammond and
disassembler
as code owners
November 10, 2023 11:00
smelc
commented
Nov 10, 2023
smelc
force-pushed
the
smelc/governance-rework-hash-arguments
branch
from
November 13, 2023 08:51
1ab7d09
to
6d6a2e8
Compare
carlhammann
reviewed
Nov 13, 2023
cardano-cli/src/Cardano/CLI/EraBased/Options/Governance/Hash.hs
Outdated
Show resolved
Hide resolved
cardano-cli/test/cardano-cli-golden/files/input/governance/committee/cc-proposal.txt
Show resolved
Hide resolved
cardano-cli/src/Cardano/CLI/Types/Errors/GovernanceHashError.hs
Outdated
Show resolved
Hide resolved
Remove CR, to be deterministic on Windows too
…e nor text to hash
smelc
force-pushed
the
smelc/governance-rework-hash-arguments
branch
from
November 13, 2023 19:47
91a2b10
to
77b7edb
Compare
carlhammann
approved these changes
Nov 14, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Roadmap to finish this PR
governance hash
commandcreate-info
update-committee
create-constitution
create-no-confidence
create-protocol-parameters-update
create-treasury-withdrawal
conway governance vote create
Context
Follow-up issues (to make this PR smaller):
How to review this PR
help
filesSorry, no smarter way to trust this change 😆
Checklist