cardano-testnet-test: allow to rewrite Conway configuration #5643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
reviewed
Jan 17, 2024
|
|
||
| mkConf :: FilePath -> Integration Conf | ||
| mkConf tempAbsPath' = | ||
| return $ Conf | ||
| { tempAbsPath = TmpAbsolutePath tempAbsPath' | ||
| , rewriteConway = id -- By default, don't change anything |
There was a problem hiding this comment.
Can you link to the PR where you use it?
There was a problem hiding this comment.
Jimbo4350
requested changes
Jan 19, 2024
| { tempAbsPath :: TmpAbsolutePath | ||
| } deriving (Eq, Show) | ||
| , -- | Function to rewrite the Conway genesis file before creating the testnet | ||
| rewriteConway :: Ledger.ConwayGenesis StandardCrypto -> Ledger.ConwayGenesis StandardCrypto |
There was a problem hiding this comment.
This is precisely what we don't want to do. We do not want to re-write things in the test. The configuration you begin with is the configuration that is used. All fiddling with genesis files should happen before the test begins and not in Haskell.
There was a problem hiding this comment.
@Jimbo4350> I don't understand your reluctance here. The rewrite is actually specified at the beginning in the test when using this API, see e.g.
Why do you think this is harmful?
3 tasks
|
Putting draft again, as this is probably superseded by #5645 |
|
Closing, as #5645 got merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it possible to rewrite the Conway genesis file before calling
create-testnet-datain integration tests. I have been using it to tweak parameters in not-yet-PRed work, but this will be useful to others.Checklist
CHANGELOG.mdfor affected package.cabalfiles are updated