-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cardano-testnet-test: allow to rewrite Conway configuration #5643
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
{-# LANGUAGE DataKinds #-} | ||
{-# LANGUAGE NamedFieldPuns #-} | ||
{-# LANGUAGE ScopedTypeVariables #-} | ||
|
||
module Testnet.Start.Types | ||
|
@@ -23,6 +24,8 @@ import Data.Word | |
|
||
import Hedgehog.Extras.Test.Base (Integration) | ||
|
||
import Cardano.Api.Ledger (StandardCrypto) | ||
import qualified Cardano.Ledger.Conway.Genesis as Ledger | ||
import Testnet.Filepath | ||
|
||
|
||
|
@@ -82,14 +85,27 @@ newtype NodeConfigurationYaml = NodeConfigurationYaml | |
{ unYamlFilePath :: FilePath | ||
} deriving (Eq, Show) | ||
|
||
newtype Conf = Conf | ||
data Conf = Conf | ||
{ tempAbsPath :: TmpAbsolutePath | ||
} deriving (Eq, Show) | ||
, -- | Function to rewrite the Conway genesis file before creating the testnet | ||
rewriteConway :: Ledger.ConwayGenesis StandardCrypto -> Ledger.ConwayGenesis StandardCrypto | ||
} | ||
|
||
instance Show Conf where | ||
-- We ignore rewriteConway | ||
show Conf { tempAbsPath } = | ||
unlines | ||
["Conf{" | ||
, " tempAbsPath=" ++ show tempAbsPath | ||
, " rewriteConway=unshowable" | ||
, "}" | ||
] | ||
|
||
mkConf :: FilePath -> Integration Conf | ||
mkConf tempAbsPath' = | ||
return $ Conf | ||
{ tempAbsPath = TmpAbsolutePath tempAbsPath' | ||
, rewriteConway = id -- By default, don't change anything | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you link to the PR where you use it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is precisely what we don't want to do. We do not want to re-write things in the test. The configuration you begin with is the configuration that is used. All fiddling with genesis files should happen before the test begins and not in Haskell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jimbo4350> I don't understand your reluctance here. The rewrite is actually specified at the beginning in the test when using this API, see e.g.
cardano-node/cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/LedgerEvents/Gov/ProposeNewConstitutionDRep.hs
Line 87 in 51b8258
Why do you think this is harmful?