fixed null world on biome set #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeachesMLG
reviewed
Dec 18, 2023
Comment on lines
234
to
246
| setIslandBiome(island, XBiome.matchXBiome(schematicConfig.overworld.biome)); | ||
| setIslandBiome(island, XBiome.matchXBiome(schematicConfig.nether.biome)); | ||
| setIslandBiome(island, XBiome.matchXBiome(schematicConfig.end.biome)); | ||
|
|
||
| for(Map.Entry<World.Environment, Boolean> enabledWorld : IridiumSkyblock.getInstance().getConfiguration().enabledWorlds.entrySet()) { | ||
| if(!enabledWorld.getValue()) { | ||
| continue; | ||
| } | ||
|
|
||
| switch (enabledWorld.getKey()) { | ||
| case NETHER: | ||
| setIslandBiome(island, XBiome.matchXBiome(schematicConfig.nether.biome)); | ||
| break; | ||
| case THE_END: | ||
| setIslandBiome(island, XBiome.matchXBiome(schematicConfig.end.biome)); | ||
| break; | ||
| default: | ||
| setIslandBiome(island, XBiome.matchXBiome(schematicConfig.overworld.biome)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can this section not stay how it is? since we already handle if the world is enabled in setIslandBiome no?
I think the previous code is alot cleaner
There was a problem hiding this comment.
ill do some testing, i also found it a bit redundant but i wanted to make sure we got rid of the problem
this still doesn't help anything if the worlds are enabled/disabled during server runtime - this is a separate issue tho
PeachesMLG
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see IS 768