Prevent obsidian platform generate in The End #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeachesMLG
reviewed
Jan 7, 2024
| @@ -62,6 +62,8 @@ public void onPlayerPortal(PlayerPortalEvent event) { | |||
| event.setCancelled(true); | |||
| return; | |||
| } | |||
| location.setY(location.getY() + 1); | |||
| event.setCanCreatePortal(false); | |||
There was a problem hiding this comment.
Suggested change
| event.setCanCreatePortal(false); | |
| if(XMaterial.supports(16)) event.setCanCreatePortal(false); |
We could do this to try maintain 1.15- This wont fix the obsidian platform for 1.15, but atleast it will still be somewhat supported
There was a problem hiding this comment.
Original code even doesn't support 1.16- ¯_(ツ)_/¯
Because java.lang.NoSuchFieldError: NETHER_WASTES
So I also fix this.
PeachesMLG
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #779
It works well.
Also fixed player not being in the correct location after teleported. (Old behavior players will be teleported inside the block)
setCanCreatePortalmay be incompatible with 1.15-, but it seems possible to abandon 1.15-?