Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent obsidian platform generate in The End #787

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Prevent obsidian platform generate in The End #787

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4210b0c
Prevent obsidian platform generate in The End
DreamVoid Jan 7, 2024
c64b72b
Fix player not being in the correct location
DreamVoid Jan 7, 2024
3c1575b
Fix 1.16- compatible.
DreamVoid Jan 8, 2024
e1351f0
Tiny change.
DreamVoid Jan 8, 2024
4afa3c1
Another Tiny change.
DreamVoid Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/com/iridium/iridiumskyblock/listeners/PlayerPortalListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ public void onPlayerPortal(PlayerPortalEvent event) {
event.setCancelled(true);
return;
}
location.setY(location.getY() + 1);
event.setCanCreatePortal(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
event.setCanCreatePortal(false);
if(XMaterial.supports(16)) event.setCanCreatePortal(false);

We could do this to try maintain 1.15- This wont fix the obsidian platform for 1.15, but atleast it will still be somewhat supported

Copy link
Contributor Author

@DreamVoid DreamVoid Jan 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original code even doesn't support 1.16- ¯_(ツ)_/¯
Because java.lang.NoSuchFieldError: NETHER_WASTES
So I also fix this.

event.setTo(location);
}
});
Expand Down
Loading