ignore missing scenes as CarPlay isn't connected anymore then#54
Merged
SamuelBrucksch merged 5 commits intomasterfrom Feb 24, 2026
Merged
ignore missing scenes as CarPlay isn't connected anymore then#54SamuelBrucksch merged 5 commits intomasterfrom
SamuelBrucksch merged 5 commits intomasterfrom
Conversation
This was referenced Feb 24, 2026
Contributor
|
packages/react-native-autoplay/ios/hybrid/HybridAutoPlay.swift:189 The use of '.await()' after 'try await' suggests a potential double-await or misuse of the custom Promise API, which could lead to unexpected behavior. |
Contributor
|
Static dictionary 'listeners' in HybridCluster is accessed and modified without proper thread synchronization, risking race conditions in concurrent scenarios. |
Contributor
|
Multiple potential thread-safety issues were detected due to unsynchronized static mutable state, and there is a possible misuse of promise awaiting in the pushTemplate function. |
SamuelBrucksch
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if template or scene functions were called from the react-native side after CarPlay was disconnected, an exception was thrown. Now, these calls are treated as no-ops instead, since scenes are no longer available after disconnection and throwing an error serves no purpose.