QA-15315 Backport from jcontent, clearing multiple localized props #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AKarmanov
previously approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Probably need to update our jahia-depends clause to latest graphql snapshot (without the snapshot qualifier) https://github.com/Jahia/content-editor/blob/master/pom.xml#L52
r3dm1ke
force-pushed
the
QA-15315
branch
2 times, most recently
from
c2eca7f to
b313e59
Compare
AKarmanov
reviewed
Jan 14, 2025
| @@ -22,6 +22,7 @@ | |||
| - 'mvn:org.jahia.modules/dx-base-demo-components/2.4.0' | |||
| - 'mvn:org.jahia.modules/digitall/2.3.0' | |||
| - 'mvn:org.jahia.modules/jcontent/2.15.0' | |||
| - 'mvn:org.jahia.modules/graphql-dxm-provider/2.22.0-SNAPSHOT' | |||
There was a problem hiding this comment.
It's ok with snapshot like that I think, but if I recall correctly it should take snapshot if you just pass 2.22.0, so when it's released we don't have to modify this file gain. You can run provisioning locally to verify, it's probably a good idea to update if it works that way.
AKarmanov
previously approved these changes
Jan 14, 2025
AKarmanov
previously approved these changes
Jan 14, 2025
gflores-jahia
previously approved these changes
Jan 14, 2025
AKarmanov
approved these changes
Jan 14, 2025
gflores-jahia
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://jira.jahia.org/browse/QA-15315
Description
Tests
The following are included in this PR
Checklist
I have considered the following implications of my change:
Documentation