Skip to content

Conversation

@arhik
Copy link
Contributor

@arhik arhik commented Jan 21, 2026

  • Replace encode_signed_varint with encode_varint for FloatIdentityOp bits since float_to_bits returns unsigned values

Also: Remove redundant encode_signed_varint overload in writer.jl that just wrapped encode_varint anyway

"""
encode_signed_varint!(buf, value)
Encode a signed integer as a variable-length integer.
Uses zigzag encoding for signed values.
"""
function encode_signed_varint!(buf::Vector{UInt8}, value::Union{UInt16, UInt32, UInt64})
# For float bits, encode as unsigned varint
encode_varint!(buf, UInt64(value))
end

- Replace encode_signed_varint with encode_varint for FloatIdentityOp bits
  since float_to_bits returns unsigned values
- Remove redundant encode_signed_varint overload in writer.jl that just
  wrapped encode_varint anyway
@arhik
Copy link
Contributor Author

arhik commented Jan 21, 2026

Fixes #44 and Fixes #45

@arhik arhik changed the title replace unsigned only varint calls with encode_varint! replace unsigned only and float only varint calls with encode_varint! Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant