Skip to content

replace unsigned only and float only varint calls with encode_varint! #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maleadt merged 1 commit into from
Jan 21, 2026
+2 −13
Merged

replace unsigned only and float only varint calls with encode_varint! #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions src/bytecode/writer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ function encode_tagged_float!(cb::CodeBuilder, identity::FloatIdentity)
encode_typeid!(cb.buf, identity.type_id)
# Value as bits (using signed varint encoding for values <= 64 bits)
bits = float_to_bits(identity.value, identity.dtype)
encode_signed_varint!(cb.buf, bits)
encode_varint!(cb.buf, bits)
end

"""
Expand All @@ -290,17 +290,6 @@ function float_to_bits(value::Float64, ::Type{T}) where T
reinterpret(UInt32, Float32(value))
end

"""
encode_signed_varint!(buf, value)

Encode a signed integer as a variable-length integer.
Uses zigzag encoding for signed values.
"""
function encode_signed_varint!(buf::Vector{UInt8}, value::Union{UInt16, UInt32, UInt64})
# For float bits, encode as unsigned varint
encode_varint!(buf, UInt64(value))
end

"""
encode_identity_array!(cb, identities)

Expand Down Expand Up @@ -544,7 +533,7 @@ function finalize_function!(func_buf::Vector{UInt8}, cb::CodeBuilder,
end

#=============================================================================
Optimization Hints
Optimization Hints
=============================================================================#

"""
Expand Down