fix: NetKAN.schema not rejecting invalid pattern for $kref and $vref in VSCode
#4258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optional capture groups allowed invalid patterns like "$kref": "#/ckan/github/foo/foo-bar/asset_WARN_match/foo-bar-baz.zip" to work, now they are rejected correctly
Danny2462
changed the title
NetKAN.schema not rejecting invalid pattern for $kref in VSCodeNetKAN.schema not rejecting invalid pattern for $kref and $vref in VSCode
HebaruSan
requested changes
Nov 11, 2024
HebaruSan
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional capture groups allowed invalid patterns like
"$kref": "#/ckan/github/foo/foo-bar/asset_WARN_match/foo-bar-baz.zip"to not result in a warning by VSCode, now they are rejected correctly:
before:
after:
Note that it warns about the spacedock pattern, which is the first of the possible patterns - this unhelpful message is a limitation of VSCode / just this regex approach of JSON schemas in general 🤷♂️
Also added escape slashes where needed, which is superfluous for the C# flavor, but required in the JavaScript flavor of regex, just to be safe.