Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NetKAN.schema not rejecting invalid pattern for $kref and $vref in VSCode #4258

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: NetKAN.schema not rejecting invalid pattern for $kref and $vref in VSCode #4258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
481b485
fix: NetKAN.schema regex fixes; made compliant with JS regex flavor
Danny2462 Nov 11, 2024
9c5b10a
Address code review comments
HebaruSan Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions NetKAN.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,39 +42,39 @@
"type": "string",
"oneOf": [
{
"pattern": "^#/ckan/spacedock/[0-9]+",
"pattern": "^#/ckan/spacedock/[0-9]+$",
"description": "Indicates that data should be fetched from SpaceDock"
},
{
"pattern": "^#/ckan/curse/[A-Za-z0-9_-]+",
"pattern": "^#/ckan/curse/[A-Za-z0-9_-]+$",
"description": "Deprecated format, no longer supported"
},
{
"pattern": "^#/ckan/github/[A-Za-z0-9_-]+/[A-Za-z0-9_-]+(/asset_match/.+|/version_from_asset/.+)?",
"pattern": "^#/ckan/github/[A-Za-z0-9_-]+/[A-Za-z0-9_-]+(/asset_match/.+|/version_from_asset/.+)?$",
"description": "Indicates that data should be fetched from the GitHub user and repo provided"
},
{
"pattern": "^#/ckan/gitlab/[A-Za-z0-9_-]+/[A-Za-z0-9_-]+",
"pattern": "^#/ckan/gitlab/[A-Za-z0-9_-]+/[A-Za-z0-9_-]+$",
"description": "Indicates that data should be fetched from the GitLab the user and repo provided"
},
{
"pattern": "^#/ckan/sourceforge/.+",
"pattern": "^#/ckan/sourceforge/.+$",
"description": "Indicates that data should be fetched from SourceForge using the repo provided"
},
{
"pattern": "^#/ckan/jenkins/.+",
"pattern": "^#/ckan/jenkins/.+$",
"description": "Indicates that data should be fetched from a Jenkins CI server using the joburl provided"
},
{
"pattern": "^#/ckan/http/.+",
"pattern": "^#/ckan/http/.+$",
"description": "Indicates data should be fetched from an HTTP server, using the URL provided"
},
{
"pattern": "^#/ckan/ksp-avc/.+",
"pattern": "^#/ckan/ksp-avc/.+$",
"description": "Indicates that data should be fetched from a KSP-AVC .version file at the URL provided"
},
{
"pattern": "^#/ckan/netkan/.+",
"pattern": "^#/ckan/netkan/.+$",
"description": "Indicates that data should be fetched from the .netkan file at the given URL"
}
]
Expand All @@ -84,11 +84,11 @@
"type": "string",
"oneOf": [
{
"pattern": "^#/ckan/ksp-avc(/.*)?",
"pattern": "^#/ckan/ksp-avc(/.*)?$",
"description": "Version information should be retrieved from an embedded KSP-AVC .version file inside the downloaded file"
},
{
"pattern": "^#/ckan/space-warp(/.*)?",
"pattern": "^#/ckan/space-warp(/.*)?$",
"description": "Version information should be retrieved from an embedded SpaceWarp swinfo.json file inside the downloaded file"
}
]
Expand Down