close #ticket-clang-format clang-formatの記法を変更する #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YKhm20020
changed the title
YKhm20020
changed the title
YKhm20020
changed the title
YKhm20020
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チェックリスト
変更点
format-check.yaml の記法を変更。
.clang-formatファイルも合わせて空白を半角スペースに統一。
他は ticket-KLI-29と同様の変更。
添付資料
詳細な理由については調査したのですが、わかりませんでした。
調べたところだと、今回変更したような記法が複数のサイトから見つかっています。
https://www.turtlestoffel.com/Clang-Format ,
https://github.com/vllm-project/vllm/blob/main/.github/workflows/clang-format.yml ,
https://community.cesium.com/t/ci-cd-deployment-issues/28272