This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
RouterCallImpl: fix unpacking 'vshard.storage.call' response #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nurzhan-saktaganov
commented
Aug 8, 2024
nurzhan-saktaganov
commented
- handle case when len(respData) < 2
- more informative logs and typo fix
- fix "err" redeclaring in inner block
- add missed "continue" operator in case when isVShardRespOk is false
* handle case when len(respData) < 2 * more informative logs and typo fix * fix "err" redeclaring in inner block * add missed "continue" operator in case when isVShardRespOk is false
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
==========================================
- Coverage 22.04% 21.67% -0.38%
==========================================
Files 9 9
Lines 635 646 +11
==========================================
Hits 140 140
- Misses 488 499 +11
Partials 7 7 ☔ View full report in Codecov by Sentry. |
This was referenced Aug 13, 2024
KaymeKaydex
suggested changes
Aug 26, 2024
api.go
Outdated
| @@ -175,19 +190,28 @@ func (r *Router) RouterCallImpl(ctx context.Context, | |||
| if !isVShardRespOk { // error | |||
| errorResp := &StorageCallAssertError{} | |||
|
|
|||
| err = future.GetTyped(&[]interface{}{&isVShardRespOk, errorResp}) | |||
| if len(respData) < 2 { | |||
| err = fmt.Errorf("unexpected response length when respData[0] == nil: %d", len(respData)) | |||
There was a problem hiding this comment.
resp data cant be nil, cause we check it before
* add more informative comments to RouterCallImpl * update CHANGELOG.md
KaymeKaydex
approved these changes
Aug 26, 2024
KaymeKaydex
pushed a commit
that referenced
this pull request
Aug 26, 2024
…ignore tmp files changes
nurzhan-saktaganov
deleted the
nsaktaganov_vshard_storage_call_resp_unpack_fix
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.