Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

Add tnt test for RouterCallImpl #56

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Conversation

nurzhan-saktaganov
Copy link
Collaborator

  • don't run TestConncurrentTopologyChange parallel with other ones
  • fix callOpts for RouterCallImpl

@nurzhan-saktaganov nurzhan-saktaganov changed the title Add tnt test for RouterCallImpl WIP: Add tnt test for RouterCallImpl Sep 4, 2024
@nurzhan-saktaganov nurzhan-saktaganov changed the base branch from nsaktaganov_resolve_issue_48 to master September 5, 2024 09:12
* don't run TestConncurrentTopologyChange parallel with other ones
* fix callOpts for RouterCallImpl
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktganov_tnt_test_coverage_up branch from f91eed5 to 4e0cbe0 Compare September 5, 2024 09:14
@nurzhan-saktaganov nurzhan-saktaganov changed the title WIP: Add tnt test for RouterCallImpl Add tnt test for RouterCallImpl Sep 5, 2024
@nurzhan-saktaganov nurzhan-saktaganov marked this pull request as ready for review September 5, 2024 09:15
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.39%. Comparing base (6de86ab) to head (72902d9).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   32.39%   32.39%           
=======================================
  Files          10       10           
  Lines         673      673           
=======================================
  Hits          218      218           
  Misses        439      439           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaymeKaydex
Copy link
Owner

@osperelygin check it please

tests/tnt/router_call_test.go Outdated Show resolved Hide resolved
@KaymeKaydex
Copy link
Owner

one of the problems that we missed is the lack of grant inside storage

box.once('access:v1', function()
	box.schema.user.grant('guest', 'super')
end)

@KaymeKaydex
Copy link
Owner

and lets add export OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES for MacOS users test safety caused by http://sealiesoftware.com/blog/archive/2017/6/5/Objective-C_and_fork_in_macOS_1013.html

@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktganov_tnt_test_coverage_up branch from c36738b to 3fc43f9 Compare September 9, 2024 21:00
tests/tnt/concurrent_topology_test.go Outdated Show resolved Hide resolved
tests/tnt/Makefile Show resolved Hide resolved
- add grants for guest user
- update comments
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the nsaktganov_tnt_test_coverage_up branch from 9d2d53f to 72902d9 Compare September 11, 2024 12:07
@nurzhan-saktaganov
Copy link
Collaborator Author

one of the problems that we missed is the lack of grant inside storage

box.once('access:v1', function()
	box.schema.user.grant('guest', 'super')
end)

Done

@nurzhan-saktaganov
Copy link
Collaborator Author

and lets add export OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES for MacOS users test safety caused by http://sealiesoftware.com/blog/archive/2017/6/5/Objective-C_and_fork_in_macOS_1013.html

Done

@KaymeKaydex KaymeKaydex merged commit 7938584 into master Sep 12, 2024
2 checks passed
@nurzhan-saktaganov nurzhan-saktaganov deleted the nsaktganov_tnt_test_coverage_up branch September 17, 2024 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants