Add tnt test for RouterCallImpl

CHANGELOG.md

@@ -9,6 +9,7 @@ REFACTOR:
 * resolve issue #38: simplify DiscoveryAllBuckets and remove suspicious if
 * resolve issue #46: drastically simplify RouterMapCallRWImpl and added tests with real tnt
 * Use typed nil pointers instead of memory allocation for EmptyMetrics and emptyLogger structs
+* New test for RouterCallImpl (and fix the old one)
 
 ## 0.0.12
 

tests/tnt/concurrent_topology_test.go

@@ -115,7 +115,13 @@ func TestConncurrentTopologyChange(t *testing.T) {
 		return
 	}
 
-	t.Parallel()
+	// suppress the below linter warning:
+	// unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
+	_ = t
+
+	// Don't run this parallel with other tests, because this test is heavy and used to detect data races.
+	// Therefore this test may impact other ones.
+	// t.Parallel()
 
 	tc := &concurrentTopologyProvider{}
 
@@ -151,7 +157,11 @@ func TestConncurrentTopologyChange(t *testing.T) {
 			bucketID := uint64((rand.Int() % totalBucketCount) + 1)
 			args := []interface{}{"arg1"}
 
-			_, _, _ = router.RouterCallImpl(ctx, bucketID, vshardrouter.CallOpts{}, "echo", args)
+			callOpts := vshardrouter.CallOpts{
+				VshardMode: vshardrouter.ReadMode,
+			}
+
+			_, _, _ = router.RouterCallImpl(ctx, bucketID, callOpts, "echo", args)
 		}
 	}()
 

tests/tnt/router_call_test.go

@@ -0,0 +1,52 @@
+package tnt_test
+
+import (
+	"context"
+	"log"
+	"math/rand"
+	"testing"
+	"time"
+
+	vshardrouter "github.com/KaymeKaydex/go-vshard-router"
+	"github.com/KaymeKaydex/go-vshard-router/providers/static"
+	"github.com/stretchr/testify/require"
+	"github.com/tarantool/go-tarantool/v2/pool"
+)
+
+func TestRouterCall(t *testing.T) {
+	if !isCorrectRun() {
+		log.Printf("Incorrect run of tnt-test framework")
+		return
+	}
+
+	t.Parallel()
+
+	ctx := context.Background()
+
+	cfg := getCfg()
+
+	router, err := vshardrouter.NewRouter(ctx, vshardrouter.Config{
+		TopologyProvider: static.NewProvider(cfg),
+		DiscoveryTimeout: 5 * time.Second,
+		DiscoveryMode:    vshardrouter.DiscoveryModeOn,
+		TotalBucketCount: totalBucketCount,
+		User:             defaultTntUser,
+		Password:         defaultTntPassword,
+	})
+
+	if err != nil {
+		panic(err)
+	}
+
+	//nolint:gosec
+	bucketID := uint64((rand.Int() % totalBucketCount) + 1)
+	args := []interface{}{"arg1"}
+
+	resp, _, err := router.RouterCallImpl(ctx, bucketID, vshardrouter.CallOpts{
+		VshardMode: vshardrouter.ReadMode,
+		PoolMode:   pool.PreferRO,
+	}, "echo", args)
+
+	require.Nil(t, err, "RouterCallImpl echo finished with no err")
+	require.EqualValues(t, args, resp, "RouterCallImpl echo resp correct")
+}

tests/tnt/routermap_call_test.go

@@ -17,6 +17,8 @@ func TestRouterMapCall(t *testing.T) {
 		return
 	}
 
+	t.Parallel()
+
 	ctx := context.Background()
 
 	cfg := getCfg()