-
Notifications
You must be signed in to change notification settings - Fork 1
Fix f-string syntax error #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @onlineinfoh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical syntax error in an f-string located within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a SyntaxError
in an f-string within client.py
. The change is effective in resolving the bug that prevented the SDK from loading. I have one suggestion to further improve the code by using the logging
module for progress reporting instead of print()
, which is a standard best practice for libraries to allow users to control output.
|
||
if progress["progress"] != previous_progress: | ||
print(f"{progress["progress"]}% - {progress['message']}") | ||
print(f"{progress['progress']}% - {progress['message']}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this change correctly fixes the f-string syntax error, it's generally better practice for a library (SDK) to use logging instead of print()
for output.1 Using the configured logger allows the user of the SDK to control the verbosity and destination of the output. I suggest using logger.info
here for progress messages, which seems more appropriate than print()
given that a logger is already in use in this file.
print(f"{progress['progress']}% - {progress['message']}") | |
logger.info(f"{progress['progress']}% - {progress['message']}") |
Style Guide References
Footnotes
-
In library code, it is recommended to use the
logging
module for all event logging, including informational messages, warnings, and errors. Avoid usingprint()
as it writes to standard output and is not easily configurable by the application that imports and uses the library. ↩
Fixes syntax error in f-string on line 273 of client.py that was preventing SDK from loading.