Guard against CAMetalDrawable with invalid pixel format. #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Calling nextDrawable may result in a nil drawable, or a drawable with no pixel format. Attempt several times to retrieve a drawable with a valid pixel format, and if unsuccessful, return an error from vkQueuePresentKHR() and vkAcquireNextImageKHR(), to force swapchain to be re-created. - Reorganize MVKQueuePresentSurfaceSubmission::execute() to detect drawable with invalid format, attach MTLCommandBuffer completion handler just before commit, and delay enqueuing MTLCommandBuffer until commit. - Refactor mvkOSVersionIsAtLeast() for clarity (unrelated).
cdavis5e
approved these changes
Sep 6, 2023
Co-authored-by: Chip Davis <cdavis5x@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nextDrawablemay result in a nil drawable, or a drawable with no pixel format. Attempt several times to retrieve a drawable with a valid pixel format, and if unsuccessful, return an error fromvkQueuePresentKHR()andvkAcquireNextImageKHR(), to force swapchain to be re-created.MVKQueuePresentSurfaceSubmission::execute()to detect drawable with invalid format, attachMTLCommandBuffercompletion handler just before commit, and delay enqueuingMTLCommandBufferuntil commit.mvkOSVersionIsAtLeast()for clarity (unrelated).Possible fix for #1990.