Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against CAMetalDrawable with invalid pixel format. #2012

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Guard against CAMetalDrawable with invalid pixel format. #2012

merged 2 commits into from
Sep 7, 2023

Commits on Sep 6, 2023

  1. Guard against CAMetalDrawable with invalid pixel format. 

    - Calling nextDrawable may result in a nil drawable, or a drawable with no
  pixel format. Attempt several times to retrieve a drawable with a valid
  pixel format, and if unsuccessful, return an error from vkQueuePresentKHR()
  and vkAcquireNextImageKHR(), to force swapchain to be re-created.
- Reorganize MVKQueuePresentSurfaceSubmission::execute() to detect drawable
  with invalid format, attach MTLCommandBuffer completion handler just before
  commit, and delay enqueuing MTLCommandBuffer until commit.
- Refactor mvkOSVersionIsAtLeast() for clarity (unrelated).
    @billhollings
    billhollings committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    7fe4963 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Update Common/MVKOSExtensions.h 

    Co-authored-by: Chip Davis <cdavis5x@gmail.com>
    @billhollings @cdavis5e
    billhollings and cdavis5e authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    6c6139c View commit details
    Browse the repository at this point in the history