Add provisional command-buffer extension#182
Conversation
Run `gen_headers.py` from KhronosGroup#161 on XML file containing KhronosGroup/OpenCL-Docs#711 new spec extensions. The only XML changes are for the `cl_khr_command_buffer` extension, which declarations gets generated at the top of `cl_ext.h` by the script. So I have taken the generated `cl_khr_command_buffer` code and applied it to the same location in master branch `cl_ext.h`.
bashbaug
left a comment
bashbaug
left a comment
There was a problem hiding this comment.
LGTM, though we should probably hold off merging this until the spec PR is merged, just in case there are some last-minute changes.
My one minor comment is that this PR includes two "features" from the codegen scripts that I think are good but we haven't formally agreed to:
- It includes a define for the extension name
CL_KHR_COMMAND_BUFFER_EXTENSION_NAME. - It include the
CL_NO_PROTOTYPESguard around the function prototypes.
I'm fine including these now, though if we want to stay consistent with the other extensions in this header at least until the codegen changes are merged we could remove them for now.
Thanks!
There was a problem hiding this comment.
Needs to be updated to remove "INFO" from the names of the command buffer query enums, see: KhronosGroup/OpenCL-Docs#711 (review)
Updated to reflect KhronosGroup/OpenCL-Docs@9295865
1. Change type of `cl_command_buffer_properties_khr` to `cl_properties` 2. Add a new `cl_command_buffer_flags_khr` type. 3. Rename `CL_COMMAND_BUFFER_PROPERTIES_KHR` to `CL_COMMAND_BUFFER_FLAGS_KHR`. 3a. Change the expected type of this to `cl_command_buffer_flags_khr`. 4. Change type of `cl_ndrange_kernel_command_properties_khr` to `cl_properties`
alycm
left a comment
alycm
left a comment
There was a problem hiding this comment.
declarations get generated at the top of cl_ext.h by the script. So I have taken the generated cl_khr_command_buffer code and applied it to the same location
It looks like the generation script goes alphabetically. No functional difference, so I don't mind where it goes.
My one minor comment is that this PR includes two "features" from the codegen scripts that I think are good but we haven't formally agreed to:
These seem harmless.
|
Spec changes are merged so I think we can merge this now, too. Thanks! |
3 participants
Run
gen_headers.pyfrom #161 on XML file containing KhronosGroup/OpenCL-Docs#711 new spec extensions.The only XML changes are for the
cl_khr_command_bufferextension, which declarations get generated at the top ofcl_ext.hby the script. So I have taken the generatedcl_khr_command_buffercode and applied it to the same location in master branchcl_ext.h.