Dont link to xcb xlib directly #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the loader linked to various windowing libraries but never made any calls into them. These can safely be removed, as including the libraries locations in the header search paths is sufficient. Because vulkan_core.h includes directfb.h without a path, it is necessary to add the search path found from pkg-config as well as the same path with `/directfb` appended to get vulkan_core.h to be able to find the header. This may be a bug in the vulkan_core.h or just an inconsistency with the way directfb is packaged on ubuntu 24, the system the change was developed on.
|
CI Vulkan-Loader build queued with queue ID 255878. |
|
CI Vulkan-Loader build # 2701 running. |
|
CI Vulkan-Loader build # 2701 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.