Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont link to xcb xlib directly #1553

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Dont link to xcb xlib directly #1553

merged 2 commits into from
Sep 13, 2024

Commits on Sep 13, 2024

  1. Only add include paths for xcb, x11, & directfb instead of linking 

    Previously, the loader linked to various windowing libraries but never
made any calls into them. These can safely be removed, as including
the libraries locations in the header search paths is sufficient.

Because vulkan_core.h includes directfb.h without a path, it is
necessary to add the search path found from pkg-config as well as
the same path with `/directfb` appended to get vulkan_core.h to be
able to find the header. This may be a bug in the vulkan_core.h
or just an inconsistency with the way directfb is packaged on
ubuntu 24, the system the change was developed on.
    @charles-lunarg
    charles-lunarg committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    307210b View commit details
    Browse the repository at this point in the history

  2. Add missing [[maybe_unused]] attributes in test_icd.cpp

    @charles-lunarg
    charles-lunarg committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d14efb1 View commit details
    Browse the repository at this point in the history