Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kong.conf.default): fix the default value of upstream_keepalive_max_requests #12643

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

chobits
Copy link
Contributor

@chobits chobits commented Feb 27, 2024

Summary

This commit fixes the discrepancy between the default value 1000 of upstream_keepalive_max_requests in the Kong.conf comments and the actual value 10000 in kong/templates/kong_defaults.lua.

Checklist

  • N/A The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • N/A There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

fix KAG-3360

@chobits chobits requested a review from Water-Melon February 27, 2024 03:07
@chobits chobits changed the title Fix/kong conf keepalive default value fix(conf): fix the default value of upstream_keepalive_max_requests Feb 27, 2024
@chobits chobits force-pushed the fix/kong-conf-keepalive-default-value branch from ed15903 to faa92c7 Compare February 27, 2024 03:09
@chobits chobits requested a review from chronolaw February 27, 2024 03:10
@chronolaw
Copy link
Contributor

Do we need to back port this PR?

@@ -1020,7 +1020,7 @@
# each upstream request to open a new
# connection.

#upstream_keepalive_max_requests = 1000 # Sets the default maximum number of
#upstream_keepalive_max_requests = 10000 # Sets the default maximum number of
Copy link
Contributor Author

@chobits chobits Feb 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭕ See the actual value here:

upstream_keepalive_max_requests = 10000

@chobits
Copy link
Contributor Author

chobits commented Feb 27, 2024

Do we need to back port this PR?

Yes, I'll backport it later. But we dont need to cherry pick it to kong-ee, because kong-ee has no this issue.

@ADD-SP ADD-SP changed the title fix(conf): fix the default value of upstream_keepalive_max_requests fix(kong.default.conf): fix the default value of upstream_keepalive_max_requests Feb 27, 2024
@ADD-SP ADD-SP changed the title fix(kong.default.conf): fix the default value of upstream_keepalive_max_requests fix(kong.default.conf): fix the default value of upstream_keepalive_max_requests Feb 27, 2024
@ADD-SP ADD-SP changed the title fix(kong.default.conf): fix the default value of upstream_keepalive_max_requests fix(kong.conf.default): fix the default value of upstream_keepalive_max_requests Feb 27, 2024
Copy link
Contributor

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this incorrect default value released? if so, we need a changelog.

@chobits chobits force-pushed the fix/kong-conf-keepalive-default-value branch 2 times, most recently from 51c81c2 to 4aaf426 Compare February 27, 2024 03:31
This commit fixes the discrepancy between the default value of
upstream_keepalive_max_requests in the Kong.conf comments and the actual value
in kong/templates/kong_defaults.lua.
@chobits chobits force-pushed the fix/kong-conf-keepalive-default-value branch from 4aaf426 to 09b23ef Compare February 27, 2024 03:34
@ADD-SP ADD-SP merged commit c5ed954 into master Feb 27, 2024
26 checks passed
@ADD-SP ADD-SP deleted the fix/kong-conf-keepalive-default-value branch February 27, 2024 05:20
github-actions bot pushed a commit that referenced this pull request Feb 27, 2024
…12643)

This commit fixes the discrepancy between the default value of
upstream_keepalive_max_requests in the Kong.conf comments and the actual value
in kong/templates/kong_defaults.lua.

(cherry picked from commit c5ed954)
@team-gateway-bot
Copy link
Collaborator

github-actions bot pushed a commit that referenced this pull request Feb 27, 2024
…12643)

This commit fixes the discrepancy between the default value of
upstream_keepalive_max_requests in the Kong.conf comments and the actual value
in kong/templates/kong_defaults.lua.

(cherry picked from commit c5ed954)
@team-gateway-bot
Copy link
Collaborator

github-actions bot pushed a commit that referenced this pull request Feb 27, 2024
…12643)

This commit fixes the discrepancy between the default value of
upstream_keepalive_max_requests in the Kong.conf comments and the actual value
in kong/templates/kong_defaults.lua.

(cherry picked from commit c5ed954)
@team-gateway-bot
Copy link
Collaborator

github-actions bot pushed a commit that referenced this pull request Feb 27, 2024
…12643)

This commit fixes the discrepancy between the default value of
upstream_keepalive_max_requests in the Kong.conf comments and the actual value
in kong/templates/kong_defaults.lua.

(cherry picked from commit c5ed954)
@team-gateway-bot
Copy link
Collaborator

@bungle bungle added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Apr 23, 2024
github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
…12643)

This commit fixes the discrepancy between the default value of
upstream_keepalive_max_requests in the Kong.conf comments and the actual value
in kong/templates/kong_defaults.lua.

(cherry picked from commit c5ed954)
@team-gateway-bot
Copy link
Collaborator

@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
…12643)

This commit fixes the discrepancy between the default value of
upstream_keepalive_max_requests in the Kong.conf comments and the actual value
in kong/templates/kong_defaults.lua.

(cherry picked from commit c5ed954)
@team-gateway-bot
Copy link
Collaborator

github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
…12643)

This commit fixes the discrepancy between the default value of
upstream_keepalive_max_requests in the Kong.conf comments and the actual value
in kong/templates/kong_defaults.lua.

(cherry picked from commit c5ed954)
@team-gateway-bot
Copy link
Collaborator

github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
…12643)

This commit fixes the discrepancy between the default value of
upstream_keepalive_max_requests in the Kong.conf comments and the actual value
in kong/templates/kong_defaults.lua.

(cherry picked from commit c5ed954)
@team-gateway-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/configuration core/templates size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants