Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport -> release/3.5.x] fix(kong.conf.default): fix the default value of upstream_keepalive_max_requests #12647

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

team-gateway-bot
Copy link
Collaborator

@team-gateway-bot team-gateway-bot commented Feb 27, 2024

Automated backport to release/3.5.x, triggered by a label in #12643.

Original description

Summary

This commit fixes the discrepancy between the default value 1000 of upstream_keepalive_max_requests in the Kong.conf comments and the actual value 10000 in kong/templates/kong_defaults.lua.

Checklist

  • N/A The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • N/A There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

KAG-3360

…12643)

This commit fixes the discrepancy between the default value of
upstream_keepalive_max_requests in the Kong.conf comments and the actual value
in kong/templates/kong_defaults.lua.

(cherry picked from commit c5ed954)
Copy link
Contributor

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value of the upstream_keepalive_max_requests in release/3.5.x is still 1000, please check if this is expected.

@chobits
Copy link
Contributor

chobits commented Feb 28, 2024

The default value of the upstream_keepalive_max_requests in release/3.5.x is still 1000, please check if this is expected.

I found it has been 10000 already, https://github.com/Kong/kong/blob/release/3.5.x/kong/templates/kong_defaults.lua#L73, do I miss something?

I just removed the changelog, 3.5.x has not released original keepalive related feature

@ADD-SP
Copy link
Contributor

ADD-SP commented Feb 28, 2024

The default value of the upstream_keepalive_max_requests in release/3.5.x is still 1000, please check if this is expected.

I found it has been 10000 already, https://github.com/Kong/kong/blob/release/3.5.x/kong/templates/kong_defaults.lua#L73, do I miss something?

I just removed the changelog, 3.5.x has not released original keepalive related feature

Thanks, my fault.

@ADD-SP ADD-SP merged commit 511fb31 into release/3.5.x Feb 28, 2024
5 checks passed
@ADD-SP ADD-SP deleted the backport-12643-to-release/3.5.x branch February 28, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core/wasm Everything relevant to [proxy-]wasm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants