tests(ai-plugins): fix flaky latency assertion #13558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way this latency is measured in the code is not granular enough to guarantee that it will always produce a non-zero result, so the assertion is changed from `>` to `>=`.
github-actions
bot
added
the
cherry-pick kong-ee
brentos
approved these changes
Aug 22, 2024
locao
approved these changes
Aug 22, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
The way this latency is measured in the code is not granular enough to guarantee that it will always produce a non-zero result, so the assertion is changed from `>` to `>=`. (cherry picked from commit 58c580f)
|
Successfully created cherry-pick PR for |
|
Successfully created backport PR for |
bungle
pushed a commit
that referenced
this pull request
Aug 23, 2024
The way this latency is measured in the code is not granular enough to guarantee that it will always produce a non-zero result, so the assertion is changed from `>` to `>=`. (cherry picked from commit 58c580f)
curiositycasualty
pushed a commit
that referenced
this pull request
Oct 15, 2024
The way this latency is measured in the code is not granular enough to guarantee that it will always produce a non-zero result, so the assertion is changed from `>` to `>=`. (cherry picked from commit 58c580f) Co-authored-by: Michael Martin <flrgh@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way this latency is measured in the code is not granular enough to guarantee that it will always produce a non-zero result, so the assertion is changed from
>to>=.KAG-5251