feat(pdk): add kong.service.request.clear_query_arg #13619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/pdk
plugins/key-auth
cherry-pick kong-ee
bungle
force-pushed
the
feat/pdk-service-request-clear-query-arg
branch
from
22f9955
to
e2aa888
Compare
gszr
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Great work on the Ada integration. @bungle could you pick the tests @battlebyte added to the other PR?
yes, thanks, I’ll add them. |
bungle
force-pushed
the
feat/pdk-service-request-clear-query-arg
branch
from
e2aa888
to
8e34d11
Compare
Test by @battlebyte were added to this PR. |
oowl
approved these changes
Sep 5, 2024
Water-Melon
reviewed
Sep 6, 2024
Water-Melon
approved these changes
Sep 6, 2024
3 tasks
Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
force-pushed
the
feat/pdk-service-request-clear-query-arg
branch
from
8e34d11
to
5bc5dd4
Compare
bungle
added
the
pr/ready (but hold merge)
…tials Fixes #12758 reported by @battlebyte. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
force-pushed
the
feat/pdk-service-request-clear-query-arg
branch
from
5bc5dd4
to
4c57265
Compare
Closed
1 task
gszr
approved these changes
Sep 9, 2024
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
kong.service.request.clear_query_argto PDK. It also contains a second commit that fixeskey-authto retain order of query string arguments when hiding the credentials.KAG-5238
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #12758 reported by @battlebyte