Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [AG-113] Gemini transformer plugins, incorrect URL and response error parsers #13703

Merged
merged 3 commits into from
Oct 14, 2024
Merged

fix: [AG-113] Gemini transformer plugins, incorrect URL and response error parsers #13703

merged 3 commits into from
Oct 14, 2024

Conversation

tysoekong
Copy link
Contributor

@tysoekong tysoekong commented Sep 23, 2024 •
edited by fffonion
Loading

Summary

This fixes two related issues:

  1. 'Gemini' when using a 'Google One' or 'Personal' subscription, was not forming the AI Transformer URL correctly, and resulted in all 404's
  2. 'from_format' parser error handling was using the wrong return argument, resulting in expected #1 got nil errors to the client

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - already up

Issue reference

AG-133

@tysoekong tysoekong added cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee backport release/3.8.x labels Sep 23, 2024
@tysoekong tysoekong marked this pull request as ready for review September 23, 2024 14:50
@tysoekong tysoekong force-pushed the fix/AG-113_gemini_transformer_plugins branch from 9bc1685 to 063c199 Compare September 23, 2024 14:52
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Sep 23, 2024
@tysoekong tysoekong force-pushed the fix/AG-113_gemini_transformer_plugins branch 3 times, most recently from f9b5367 to 3ee4797 Compare September 30, 2024 15:50
@fffonion fffonion force-pushed the fix/AG-113_gemini_transformer_plugins branch from 3ee4797 to a612bb7 Compare October 14, 2024 11:14
@fffonion fffonion merged commit b49cf31 into master Oct 14, 2024
26 checks passed
@fffonion fffonion deleted the fix/AG-113_gemini_transformer_plugins branch October 14, 2024 18:13
github-actions bot pushed a commit that referenced this pull request Oct 14, 2024
@tysoekong @github-actions
fix(llm): fix gemini transformer plugins, incorrect URL and response …
1a4d917 
…error parsers (#13703)

* fix(gemini-ai): incorrect URL parser for transformer plugins

* fix(ai-transformers): incorrect return parameter used for parser error handling

AG-113

(cherry picked from commit b49cf31)
@team-gateway-bot team-gateway-bot mentioned this pull request Oct 14, 2024
Merged
3 tasks
@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/3.8.x:

@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

fffonion pushed a commit that referenced this pull request Oct 17, 2024
@team-gateway-bot @tysoekong
fix(llm): fix gemini transformer plugins, incorrect URL and response …
cb511ee 
…error parsers (#13703) (#13753)

* fix(gemini-ai): incorrect URL parser for transformer plugins

* fix(ai-transformers): incorrect return parameter used for parser error handling

AG-113

(cherry picked from commit b49cf31)

Co-authored-by: Jack Tysoe <91137069+tysoekong@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion approved these changes

@oowl oowl oowl approved these changes

Assignees

@tysoekong tysoekong

Labels
author/community PRs from the open-source community (not Kong Inc) backport release/3.8.x cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/ai-proxy plugins/ai-request-transformer plugins/ai-response-transformer schema-change-noteworthy size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tysoekong @team-gateway-bot @fffonion @oowl