Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport -> release/3.8.x] fix: [AG-113] Gemini transformer plugins, incorrect URL and response error parsers #13753

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[backport -> release/3.8.x] fix: [AG-113] Gemini transformer plugins, incorrect URL and response error parsers #13753

merged 1 commit into from
Oct 17, 2024

Conversation

team-gateway-bot
Copy link
Collaborator

Automated backport to release/3.8.x, triggered by a label in #13703.

Original description

Summary

This fixes two related issues:

  1. 'Gemini' when using a 'Google One' or 'Personal' subscription, was not forming the AI Transformer URL correctly, and resulted in all 404's
  2. 'from_format' parser error handling was using the wrong return argument, resulting in expected #1 got nil errors to the client

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - already up

Issue reference

AG-113

@tysoekong @github-actions
fix(llm): fix gemini transformer plugins, incorrect URL and response …
1a4d917 
…error parsers (#13703)

* fix(gemini-ai): incorrect URL parser for transformer plugins

* fix(ai-transformers): incorrect return parameter used for parser error handling

AG-113

(cherry picked from commit b49cf31)
@team-gateway-bot team-gateway-bot mentioned this pull request Oct 14, 2024
Merged
3 tasks
@team-gateway-bot team-gateway-bot removed the author/community PRs from the open-source community (not Kong Inc) label Oct 14, 2024
@tysoekong
Copy link
Contributor

@fffonion Easy backport, just need approve

@fffonion fffonion merged commit cb511ee into release/3.8.x Oct 17, 2024
66 checks passed
@fffonion fffonion deleted the backport-13703-to-release/3.8.x branch October 17, 2024 07:59
@kevwilliams kevwilliams added this to the 3.8.1 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion approved these changes

@oowl oowl oowl approved these changes

Assignees

@tysoekong tysoekong

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/ai-proxy plugins/ai-request-transformer plugins/ai-response-transformer schema-change-noteworthy size/L
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.
5 participants
@team-gateway-bot @tysoekong @fffonion @oowl @kevwilliams