Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update commitment encoding #11

Merged
merged 2 commits into from
May 18, 2024
Merged

Update commitment encoding #11

merged 2 commits into from
May 18, 2024

Conversation

EthenNotEthan
Copy link
Collaborator

@EthenNotEthan EthenNotEthan commented May 17, 2024 •
edited
Loading

Changes

  • Converted DaCommitment to GenericCommitment to align with OP implementation
  • Reduced server side encoding to only prepend DA_TYPE, DA_VERSION onto the commitment when writing to response body in put method since OP stack will handle the commitment type encoding

@EthenNotEthan EthenNotEthan changed the title Epociask fix encoding Update commitment encoding May 17, 2024
@EthenNotEthan EthenNotEthan requested a review from teddyknox May 17, 2024 23:39
teddyknox
teddyknox approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@teddyknox teddyknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EthenNotEthan EthenNotEthan merged commit 1b50ef2 into main May 18, 2024
3 checks passed
@EthenNotEthan EthenNotEthan deleted the epociask--fix-encoding branch May 21, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teddyknox teddyknox teddyknox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EthenNotEthan @teddyknox