Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commitment encoding #11

Merged
merged 2 commits into from
May 18, 2024
+8 −6
Merged

Update commitment encoding #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1758602
fix(op-plasma-eigenda): Fix encoding
EthenNotEthan May 17, 2024
2165a28
fix(op-plasma-eigenda): Fix encoding - rm dbug stmts
EthenNotEthan May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions commitment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ import (
"github.com/ethereum/go-ethereum/crypto"
)

// ErrCommitmentLength is returned when the commitment length is invalid.
var ErrCommitmentLength = errors.New("invalid commitment length")

// ErrInvalidCommitment is returned when the commitment cannot be parsed into a known commitment type.
var ErrInvalidCommitment = errors.New("invalid commitment")

Expand All @@ -18,8 +21,8 @@ type CommitmentType byte

const (
// default commitment type for the DA storage.
Keccak256CommitmentType CommitmentType = 0x00
DaService CommitmentType = 0x01
Keccak256CommitmentType CommitmentType = 0
GenericCommitment CommitmentType = 1
)

type ExtDAType byte
Expand Down Expand Up @@ -75,11 +78,10 @@ func DecodeKeccak256(commitment []byte) (Keccak256Commitment, error) {
return c, nil
}

// NOTE - This logic will need to be migrated into layr-labs/op-stack directly
type EigenDACommitment []byte

func (c EigenDACommitment) Encode() []byte {
return append([]byte{byte(DaService), byte(EigenDA), byte(EigenV0)}, c...)
return append([]byte{byte(EigenDA), byte(EigenV0)}, c...)
}

func (c EigenDACommitment) TxData() []byte {
Expand All @@ -88,9 +90,9 @@ func (c EigenDACommitment) TxData() []byte {

func DecodeEigenDACommitment(commitment []byte) (EigenDACommitment, error) {
if len(commitment) <= 3 {
return nil, ErrInvalidCommitment
return nil, ErrCommitmentLength
}
if commitment[0] != byte(DaService) {
if commitment[0] != byte(GenericCommitment) {
return nil, ErrInvalidCommitment
}

Expand Down
Loading