Remove logs from UI library #21
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/app/[locale]/page.tsx
Outdated
| /** | ||
| * @dev temporary removing some logs in client. | ||
| */ | ||
| require("../../../tools/removeLogs"); |
There was a problem hiding this comment.
You can't use alias? :)
There was a problem hiding this comment.
Sadly no, it doesn't work in test ... Idk why. Look at my second commit.
There was a problem hiding this comment.
if you do
| require("../../../tools/removeLogs"); | |
| import "@/tools/removeLogs" |
This don't works?
There was a problem hiding this comment.
Ok when doing that I had an error saying that the file wasn't a module so I just added module.exports = {} and it worked. Cool, thanks for the heads up @mcayuelas-ledger !
jest.setup.js
Outdated
| /** | ||
| * @dev temporary removing some logs. | ||
| */ | ||
| require("./tools/removeLogs"); | ||
|
|
There was a problem hiding this comment.
We should not mix require and import. You can use an import here.
| /** | ||
| * @dev temporary removing some logs in client. | ||
| */ | ||
| import("@/tools/removeLogs"); | ||
|
|
There was a problem hiding this comment.
I think that we should parse errors only for tests. I'm not convinced doing that at runtime for the client.
📝 Description
Temporarily removing logs coming from
@ledgerhq/react-uifor test and client/server components. It's much easier to develop.❓ Context
📸 Demo
🚀 Expectations to reach
Pull Requests must pass the CI and be internally validated in order to be merged.