This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Remove logs from UI library #21
Open
sshmaxime
wants to merge
4
commits into
main
Choose a base branch
from
support/remove-logs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+48
β0
Open
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,10 @@ | ||
"use client"; | ||
|
||
/** | ||
* @dev temporary removing some logs in client. | ||
*/ | ||
import("@/tools/removeLogs"); | ||
|
||
Comment on lines
+3
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that we should parse errors only for tests. I'm not convinced doing that at runtime for the client. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even for the server |
||
import Image from "next/image"; | ||
import styles from "./page.module.css"; | ||
import ThemeSelector from "@/components/ThemeSelector"; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/** | ||
* @dev We are removing error and warning logs from `@ledgerhq/react-ui`. | ||
*/ | ||
const originalError = console.error; | ||
const originalWarn = console.warn; | ||
|
||
const EXCLUDED_ERRORS = [ | ||
"If you accidentally passed it from a parent component, remove it from the DOM element.", | ||
"You provided a `checked` prop to a form field without an `onChange` handler.", | ||
]; | ||
|
||
const EXCLUDED_WARNINGS = [ | ||
" is being sent through to the DOM, which will likely trigger a React console error.", | ||
]; | ||
|
||
console.error = (...args) => { | ||
const error = args.join(); | ||
if (EXCLUDED_ERRORS.some((excluded) => error.includes(excluded))) { | ||
return; | ||
} | ||
originalError.call(console, ...args); | ||
}; | ||
|
||
console.warn = (...args) => { | ||
const warning = args.join(); | ||
if (EXCLUDED_WARNINGS.some((excluded) => warning.includes(excluded))) { | ||
return; | ||
} | ||
originalWarn.call(console, ...args); | ||
}; | ||
|
||
module.exports = {}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not mix require and import. You can use an import here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch