Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard_app: allow URL to be defined in app makefile #388

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

sgliner-ledger
Copy link
Contributor

Description

Allow app to define only the URL in its makefile

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (beb209d) 69.09% compared to head (b570644) 69.09%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   69.09%   69.09%           
=======================================
  Files          11       11           
  Lines         864      864           
=======================================
  Hits          597      597           
  Misses        267      267           
Flag Coverage Δ
unittests 69.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sgliner-ledger sgliner-ledger merged commit 4c80b5f into master Jul 31, 2023
160 checks passed
@sgliner-ledger sgliner-ledger deleted the improve-standard-webusb branch July 31, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants