Tdj/update workflow to build on stax #465
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
=======================================
Coverage 59.47% 59.47%
=======================================
Files 12 12
Lines 1683 1683
=======================================
Hits 1001 1001
Misses 682 682
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tdejoigny-ledger
force-pushed
the
tdj/update_workflow_to_build_on_Stax
branch
3 times, most recently
from
3a00178
to
11a2877
Compare
tdejoigny-ledger
force-pushed
the
tdj/update_workflow_to_build_on_Stax
branch
from
11a2877
to
a6e057f
Compare
| @@ -262,6 +328,14 @@ jobs: | |||
| build_path=$(echo '${{ env.build_path_list}}' | sed -n 's/.*"${{ matrix.repo_name }}"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/p') | |||
| echo "build_path=$build_path" >> $GITHUB_ENV | |||
|
|
|||
| - name: Build for Stax | |||
| run: | | |||
| if echo "${{ env.build_for_stax_list }}" | grep -q "${{ matrix.repo_name }}" || [[ "${{ inputs.run_stax }}" ]]; then | |||
There was a problem hiding this comment.
You can get rid of the run_stax argument I think :)
There was a problem hiding this comment.
could be useful to check if an app build on Stax...
There was a problem hiding this comment.
I would argue that we have the app tester for this ?
There was a problem hiding this comment.
I would argue that we have the app tester for this ?
There was a problem hiding this comment.
I prefer to keep it for now because it's easier to run directly the workflow with run_stax flag in order to see which app listed in SDK CI is Ok for build and could be added in build_for_stax list
Description
Update workflow to be able to build some apps on Stax
Changes include