Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tdj/update workflow to build on stax #465

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Tdj/update workflow to build on stax #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 79 additions & 5 deletions .github/workflows/build_all_apps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,73 @@ env:
\"app-thorchain\" : \"./app\" ,
\"app-xxnetwork\" : \"./app\" }
"

build_for_stax_list: '
{\"app-solana\",
\"app-hedera\",
\"app-acala\",
\"app-bitcoin-new\",
\"app-mina\",
\"app-tezos\",
\"app-plugin-nested\",
\"app-plugin-staderlabs\",
\"app-plugin-lido\",
\"app-plugin-paraswap\",
\"app-plugin-1inch\",
\"app-plugin-yearn\",
\"app-plugin-quickswap\",
\"app-plugin-cometh\",
\"app-plugin-stakedao\",
\"app-plugin-ricochet\",
\"app-plugin-poap\",
\"app-plugin-angle\",
\"app-plugin-kiln\",
\"app-plugin-alkemi\",
\"app-plugin-nft\",
\"app-plugin-harvest\",
\"app-plugin-opensea-new\",
\"app-plugin-rarible\",
\"app-plugin-cbridge\",
\"app-plugin-ribbon\",
\"app-plugin-art-blocks\",
\"app-plugin-boilerplate\",
\"app-stellar\",
\"app-exchange\",
\"app-ssh-agent\",
\"app-neo\",
\"app-boilerplate\",
\"app-xrp\",
\"app-recovery-check\",
\"app-near\",
\"app-nervos\",
\"app-cardano\",
\"app-kusama\",
\"app-polymesh\",
\"app-monero\",
\"app-celo-spender\",
\"app-cosmos\",
\"app-statemine\",
\"app-polkadot\",
\"app-zilliqa\",
\"app-nem\",
\"app-eos\",
\"app-u2f\",
\"app-fantom\",
\"app-multiversx\",
\"app-symbol\",
\"app-vechain\",
\"app-decred\",
\"app-cryptocom\",
\"app-icp\",
\"app-tron\",
\"app-bitcoin\",
\"app-flow\",
\"app-passwords\",
\"app-secret\",
\"app-binance\"}
'
# App-Ethereum to add in the previous list

repo_list: '
{\"repo_name\":[
\"app-velas\",
Expand Down Expand Up @@ -138,7 +205,6 @@ env:
\"app-filecoin\",
\"app-algorand\",
\"app-dock\",
\"app-plugin-opensea\",
\"app-ton-new\",
\"app-tron\",
\"app-khala\",
Expand Down Expand Up @@ -205,13 +271,14 @@ env:
\"app-ark\",
\"app-ardor\",
\"app-aion\",
\"app-neo3\",
]}
'
# Failing apps
#\"app-starknet\",
#\"app-avalanche\",
#\"app-kadena\",

#\"app-security-key\",
sgliner-ledger marked this conversation as resolved.
Show resolved Hide resolved
#\"app-starknet\",
#\"app-panacea\",
#\"app-insolar\",
#\"app-dgld\",
Expand All @@ -226,7 +293,6 @@ env:
#\"app-equilibrium\",
#\"app-revealer\",
#\"app-rise\",
#\"app-neo3\",
#\"app-keepass\",
#\"app-bitsong\",

Expand Down Expand Up @@ -262,6 +328,14 @@ jobs:
build_path=$(echo '${{ env.build_path_list}}' | sed -n 's/.*"${{ matrix.repo_name }}"[[:space:]]*:[[:space:]]*"\([^"]*\)".*/\1/p')
echo "build_path=$build_path" >> $GITHUB_ENV

- name: Build for Stax
run: |
if echo "${{ env.build_for_stax_list }}" | grep -q "${{ matrix.repo_name }}" || [[ "${{ inputs.run_stax }}" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get rid of the run_stax argument I think :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be useful to check if an app build on Stax...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue that we have the app tester for this ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue that we have the app tester for this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep it for now because it's easier to run directly the workflow with run_stax flag in order to see which app listed in SDK CI is Ok for build and could be added in build_for_stax list

echo "build_for_stax=true" >> $GITHUB_ENV
else
echo "build_for_stax=false" >> $GITHUB_ENV
fi

- name: Clone SDK
uses: actions/checkout@v3
with:
Expand All @@ -284,7 +358,7 @@ jobs:
TARGET=nanos2 BOLOS_SDK=$GITHUB_WORKSPACE/sdk make

- name: Build Stax
if: ${{ inputs.run_stax == true }}
if: ${{ env.build_for_stax == 'true' }}
run: |
[ -n '${{ env.build_path }}' ] && cd ${{ env.build_path }}
TARGET=stax BOLOS_SDK=$GITHUB_WORKSPACE/sdk make
Loading