Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing lines in long tag/values, with no "More" button #761

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to fix missing lines in long tag/values, with no "More" button
In some specific cases, if the value field is too long to fit in the max number of lines, but not tto long to fit in the max available height, the text will be presented in shortened version (with "..."), but without "More" button enabling to see full value in a modal screen.

Changes include

  • [*] Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.96%. Comparing base (74a8e35) to head (2486a54).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   59.96%   59.96%           
=======================================
  Files          12       12           
  Lines        1721     1721           
=======================================
  Hits         1032     1032           
  Misses        689      689           
Flag Coverage Δ
unittests 59.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger merged commit ac62f3e into master Sep 4, 2024
198 checks passed
@nroggeman-ledger nroggeman-ledger deleted the fix-missing-lines-in-long-values branch September 4, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants