Networking fixes #36
Open
Networking fixes #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
LeeVangraefschepe
commented
Dec 2, 2023
LeeVangraefschepe
commented
- Only the basepacket function got called when setting data for a packet.
- Client no longer needs ticks. The receive call is blocking and doesnt spam the thread.
- Changed error to warning when connection
Only the basepacket function got called when setting data for the packet.
Client no longer needs ticks. The receive call is blocking and doesnt spam the thread.
AtlantiaKing
reviewed
Dec 3, 2023
| void leap::networking::LeapClient::HandleReceiveUDP() | ||
| { | ||
| // Receive a response from the server | ||
| std::vector<char> buffer{}; |
Collaborator
There was a problem hiding this comment.
This seems very unefficient because you create a new vector of, in this case, 1024 bytes everytime a new message is being received. 1kB per message on UDP seems a lot of allocations/deallocations. Maybe move the buffer to the UDPRun function and give a reference to the HandleReceiveUDP function?
Owner
Author
There was a problem hiding this comment.
This vector is moved to the packet. But there is an option to pool these buffers to decrease the usage of allocations & deallocations.
The client code now reuses the buffer for the incoming packets. (copy is still made for the package itself)
Error messages are made more clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.