[litgpt benchmark] enable force_recompute_fp8_weight_in_bwd when torchao.float8 is used with FSDP2
#1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanYashchuk
approved these changes
Dec 17, 2024
ref: pytorch/ao@e919558 Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
crcrpar
force-pushed
the
crpa/ao-recompute_fp8_weight_in_bwd
branch
from
a824ae4 to
9ad3327
Compare
lantiga
approved these changes
Jan 20, 2025
riccardofelluga
pushed a commit
that referenced
this pull request
Jan 27, 2025
…orchao.float8` is used with FSDP2 (#1528) Signed-off-by: Masaki Kozuki <mkozuki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title.
ref: pytorch/ao@e919558
With 8 H100s and pjnl-20241209.
Used command is:
torchrun --nproc-per-node 8 --local-ranks-filter 0 --role rank --tee 3 thunder/benchmarks/benchmark_litgpt.py --model_name <MODEL_NAME> --compile inductor --distributed_mode fsdp2 --shard_mode zero2 --use_torchao_fp8_linear true --use_torchao_fp8_allgather true --use_torchao_fp8_precompute_scale_for_fsdp trueLlama-2-7b-hf.
Llama-3-8B
cc @crcrpar