Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[litgpt benchmark] enable force_recompute_fp8_weight_in_bwd when torchao.float8 is used with FSDP2 #1528

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[litgpt benchmark] enable force_recompute_fp8_weight_in_bwd when torchao.float8 is used with FSDP2 #1528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions thunder/benchmarks/benchmark_litgpt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ def __post_init__(self) -> None:
cast_config_grad_output=CastConfig(ScalingType.DYNAMIC),
enable_fsdp_float8_all_gather=self.use_fp8_allgather and self.is_fsdp2,
enable_pre_and_post_forward=False,
force_recompute_fp8_weight_in_bwd=self.is_fsdp2,
)
self.precompute_scale = (
self.is_fsdp2 and self.use_fp8_allgather and self.use_torchao_fp8_precompute_float8_dynamic_scale_for_fsdp
Expand Down
Loading