-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransformerEngine - Intermediate tensor sharding #695
Merged
t-vi
merged 10 commits into
Lightning-AI:main
from
kshitij12345:te-intermediate-sharding
Jul 5, 2024
Merged
TransformerEngine - Intermediate tensor sharding #695
t-vi
merged 10 commits into
Lightning-AI:main
from
kshitij12345:te-intermediate-sharding
Jul 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… te-intermediate-sharding
…ghtning-thunder into te-intermediate-sharding
… te-intermediate-sharding
kshitij12345
changed the title
[WIP] TransformerEngine - Intermediate Sharding
TransformerEngine - Intermediate Sharding
Jul 4, 2024
kshitij12345
changed the title
TransformerEngine - Intermediate Sharding
TransformerEngine - Intermediate tensor sharding
Jul 4, 2024
IvanYashchuk
approved these changes
Jul 5, 2024
t-vi
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kshitij12345 @IvanYashchuk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransformerEngine added the ability to shard intermediate activation tensors in v1.8. Currently, we save global/world sized activation for backward pass. Using this, we can lower the peak memory usage at the cost of added comms - as we will shard these intermediate tensor and gather them before the backward computation.
TE PR: NVIDIA/TransformerEngine#687
In this PR, we use make this option opt-in using thunder.jit compile argument -
fp8_shard_intermediate_activation
.Example usage:
model = thunder.jit(model, executors=executors, fp8_shard_intermediate_activation=True)
Testing
Updated the distributed test to use this option. Have tested with existing tests in
test_transformer_engine_executor.py
andtest_ddp.py -k transformer
with TE v1.7 (current stable), v1.8 and v1.9 (current main).Benchmark
Command -
Without FP8 Intermediate Sharding
With FP8 Intermediate Sharding
Patch to enable sharding in `benchmark_litgpt.py`