Skip to content

Consistent Contract contentproperties #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TheBonheurs merged 5 commits into from
Jan 13, 2026
Merged

Consistent Contract contentproperties #58

TheBonheurs merged 5 commits into from
Jan 13, 2026

Conversation

@Voles
Copy link
Collaborator

@Voles Voles commented Dec 17, 2025 •
edited
Loading

  1. We gebruikten de property content voor het GET /contracts endpoint en contract_content voor het POST /contracts endpoint.
    Ook de endpoints PUT /contracts/{hash}/accept / reject / revoke maakten gebruik van contract_content.
    Dat is verwarrend. In deze PR hebben we alle instanties aangepast van contract_content naar content.
  2. In de sectie 'Content hash' en 'Grant hash' werd gerefereerd naar de property content.algorithm. Die bestaat niet, dat moet content.hash_algorithm zijn.

Voles added 5 commits December 17, 2025 16:13
@Voles
Ensure request / response bodies consistently use content for the C…
b6a1fa0 
…ontract content.

Instead of mixing `contract_content` and `content`. That is unnecessary and confusing.
@Voles
Fix property name algorithm -> hash_algorithm for the Content has…
54513a3 
…h section

`algorithm` is not used. The correct property name from the OAS is `hash_algorithm`.
@Voles
Remove redundant contract. prefix from the content hash section
f9558db
@Voles
Fix reference to wrong step number 13 in the content hash section
9192720
@Voles
Fix property name algorithm -> hash_algorithm for the Grant hash …
69c3378 
…section

`algorithm` is not used. The correct property name from the OAS is `hash_algorithm`.
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Preview link voor pull request
Diff met W3CDiff

@Voles Voles requested a review from ronaldkoster December 17, 2025 15:32
@TheBonheurs TheBonheurs merged commit 747fc39 into develop Jan 13, 2026
15 of 16 checks passed
@TheBonheurs TheBonheurs deleted the consistent-contracts branch January 13, 2026 09:46
@github-project-automation github-project-automation bot moved this from Intake to Done in Digikoppeling board Jan 13, 2026
@github-actions github-actions bot added the Status: Klaar voor release Het voorstel is verwerkt en klaar voor de volgende release. label Jan 13, 2026
@TheBonheurs TheBonheurs mentioned this pull request Jan 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronaldkoster ronaldkoster Awaiting requested review from ronaldkoster

Assignees

No one assigned

Labels

Status: Klaar voor release Het voorstel is verwerkt en klaar voor de volgende release.

Projects

Digikoppeling board
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Voles @TheBonheurs