fix: Planet Selection Screen not rendering correctly on real phone #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd explicitly in PlanetSurfaceView
-Use topBar and content slots to better structure components
|
mehdi-hamirifou
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
PlanetSelectionScreento address layout issues encountered on physical devices. The modifications ensure all components are displayed correctly and are no longer obscured by theGLSurfaceView. Additionally, a clear separation between UI elements and OpenGL rendering was introduced.Replaced Surface with Scaffold:
PlanetSelectionScreento use Scaffold for separation of the top bar (UI components) and the content (OpenGL rendering).PlanetSurfaceView:
This PR is related to PR #298