Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Planet Selection Screen not rendering correctly on real phone #305

Merged
merged 4 commits into from
Dec 19, 2024
Merged

fix: Planet Selection Screen not rendering correctly on real phone #305

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45b558a
fix: set GLSurfaceView to be transparent and place it in the backgrou…
Kenzoud Dec 19, 2024
5dca02c
fix: replace Surface with Scaffold in PlanetSelectionScreen
Kenzoud Dec 19, 2024
8487e36
fix: separate PlanetSelectionRow an the text from the OpenGL content …
Kenzoud Dec 19, 2024
264724c
test(planet-selection): add unit tests forPlanetSelectionScreen compo…
Kenzoud Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: set GLSurfaceView to be transparent and place it in the backgrou… 
…nd explicitly in PlanetSurfaceView
  • Loading branch information
@Kenzoud
Kenzoud committed Dec 19, 2024
commit 45b558a6afd7eb4a434f5cec9ba88d847d37f89a
6 changes: 6 additions & 0 deletions app/src/main/java/com/github/lookupgroup27/lookup/model/planetselection/PlanetSurfaceView.kt
View file
Original file line number Diff line number Diff line change
@@ -2,6 +2,7 @@ package com.github.lookupgroup27.lookup.model.planetselection

import android.annotation.SuppressLint
import android.content.Context
import android.graphics.PixelFormat
import android.opengl.GLSurfaceView
import com.github.lookupgroup27.lookup.model.map.planets.PlanetData

@@ -26,6 +27,11 @@ class PlanetSurfaceView(context: Context, private var planet: PlanetData) : GLSu

// Render only when the content changes
renderMode = RENDERMODE_CONTINUOUSLY

// Enable transparency
setZOrderOnTop(false)
setZOrderMediaOverlay(false)
holder.setFormat(PixelFormat.TRANSLUCENT)
}

/**
Loading