Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to modernise package a bit #61

Merged
merged 5 commits into from
Oct 29, 2023
Merged

Try to modernise package a bit #61

merged 5 commits into from
Oct 29, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 29, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98c6b34) 56.53% compared to head (eb47d43) 56.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   56.53%   56.06%   -0.47%     
==========================================
  Files          12       12              
  Lines         375      371       -4     
  Branches       49       51       +2     
==========================================
- Hits          212      208       -4     
  Misses        160      160              
  Partials        3        3              
Files Coverage Δ
MDAnalysisData/__init__.py 100.00% <100.00%> (ø)
MDAnalysisData/base.py 98.30% <100.00%> (-0.03%) ⬇️
MDAnalysisData/datasets.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pep8speaks
Copy link

pep8speaks commented Oct 29, 2023

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 381:80: E501 line too long (84 > 79 characters)
Line 471:80: E501 line too long (80 > 79 characters)
Line 474:80: E501 line too long (84 > 79 characters)

Line 26:80: E501 line too long (80 > 79 characters)
Line 27:80: E501 line too long (86 > 79 characters)
Line 28:80: E501 line too long (81 > 79 characters)
Line 33:80: E501 line too long (83 > 79 characters)
Line 45:80: E501 line too long (83 > 79 characters)
Line 222:80: E501 line too long (87 > 79 characters)
Line 224:80: E501 line too long (86 > 79 characters)
Line 252:80: E501 line too long (85 > 79 characters)
Line 284:80: E501 line too long (87 > 79 characters)
Line 286:80: E501 line too long (83 > 79 characters)
Line 288:80: E501 line too long (86 > 79 characters)
Line 888:80: E501 line too long (85 > 79 characters)
Line 978:80: E501 line too long (80 > 79 characters)
Line 981:80: E501 line too long (87 > 79 characters)
Line 1419:80: E501 line too long (84 > 79 characters)
Line 1620:80: E501 line too long (80 > 79 characters)
Line 1623:80: E501 line too long (84 > 79 characters)
Line 1893:80: E501 line too long (83 > 79 characters)
Line 1988:80: E501 line too long (80 > 79 characters)
Line 1989:80: E501 line too long (85 > 79 characters)
Line 2030:80: E501 line too long (84 > 79 characters)
Line 2032:80: E501 line too long (83 > 79 characters)

Comment last updated at 2023-10-29 06:54:50 UTC

@IAlibay IAlibay requested a review from orbeckst October 29, 2023 07:11
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package says "thank you" for some TLC.

LGTM!

@orbeckst orbeckst self-assigned this Oct 29, 2023
@orbeckst orbeckst merged commit 657d2b6 into master Oct 29, 2023
10 checks passed
@orbeckst orbeckst deleted the update-things branch October 29, 2023 17:03
@orbeckst orbeckst linked an issue Oct 29, 2023 that may be closed by this pull request
@orbeckst orbeckst mentioned this pull request Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make next release 3.6+?
3 participants