-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding py3.12 to full dependency CI checks #4329
Conversation
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4329 +/- ##
===========================================
+ Coverage 93.37% 93.78% +0.40%
===========================================
Files 170 184 +14
Lines 22295 25323 +3028
Branches 4075 4623 +548
===========================================
+ Hits 20818 23749 +2931
- Misses 962 1059 +97
Partials 515 515 ☔ View full report in Codecov by Sentry. |
Looks like we're blocked by openmm |
I think its estimated to be a few weeks away as waiting for 8.1 |
@IAlibay can we label the PR as draft or WIP? Or is it something that needs someone assigned as PR shepherd? |
Just cycling - openmm 8.1 is out, I'm not sure if there are any other blockers for py3.12. |
Odd we're blocked on PyTNG now.. I thought that was fixed. Here's the problem: conda-forge/pytng-feedstock#23 the migration never happened... |
This should be good to go. |
Cheers @RMeli ! |
@IAlibay I'm on mobile, but I was trying to look into why one of the action failed. Was that expected? |
👀 An action failed? How odd it looked green on my end - let me check. |
I'm not sure what happened @RMeli - sorry I might have missed something on my end. If merge CI returns green I'm going to say it's probably fine? (we only touched GH actions here anyways) https://github.com/MDAnalysis/mdanalysis/actions/runs/7309090802 |
Looks like it all went green, should be good to go :) |
Yes, I can confirm all green on develop, so all good. |
Running full deps py3.12 check in github actions now.
Just testing things out to see which upstream dependency we're currently waiting on.
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4329.org.readthedocs.build/en/4329/