Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding py3.12 to full dependency CI checks #4329

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 28, 2023

Just testing things out to see which upstream dependency we're currently waiting on.

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4329.org.readthedocs.build/en/4329/

@github-actions
Copy link

github-actions bot commented Oct 28, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (707e043) 93.37% compared to head (ddae52b) 93.78%.
Report is 29 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4329      +/-   ##
===========================================
+ Coverage    93.37%   93.78%   +0.40%     
===========================================
  Files          170      184      +14     
  Lines        22295    25323    +3028     
  Branches      4075     4623     +548     
===========================================
+ Hits         20818    23749    +2931     
- Misses         962     1059      +97     
  Partials       515      515              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 28, 2023

Looks like we're blocked by openmm

@hmacdope
Copy link
Member

Looks like we're blocked by openmm

I think its estimated to be a few weeks away as waiting for 8.1

@orbeckst
Copy link
Member

@IAlibay can we label the PR as draft or WIP? Or is it something that needs someone assigned as PR shepherd?

@IAlibay IAlibay closed this Dec 15, 2023
@IAlibay IAlibay reopened this Dec 15, 2023
@IAlibay
Copy link
Member Author

IAlibay commented Dec 15, 2023

Just cycling - openmm 8.1 is out, I'm not sure if there are any other blockers for py3.12.

@IAlibay IAlibay changed the title Try adding py3.12 to full dependency CI checks [WIP] Try adding py3.12 to full dependency CI checks Dec 15, 2023
@IAlibay
Copy link
Member Author

IAlibay commented Dec 15, 2023

Odd we're blocked on PyTNG now.. I thought that was fixed.

Here's the problem: conda-forge/pytng-feedstock#23 the migration never happened...

@IAlibay IAlibay changed the title [WIP] Try adding py3.12 to full dependency CI checks Adding py3.12 to full dependency CI checks Dec 22, 2023
@IAlibay IAlibay requested a review from RMeli December 23, 2023 14:29
@IAlibay
Copy link
Member Author

IAlibay commented Dec 23, 2023

This should be good to go.

@IAlibay
Copy link
Member Author

IAlibay commented Dec 23, 2023

Cheers @RMeli !

@IAlibay IAlibay merged commit edda942 into develop Dec 23, 2023
41 of 42 checks passed
@IAlibay IAlibay deleted the full-deps-py312 branch December 23, 2023 15:35
@RMeli
Copy link
Member

RMeli commented Dec 23, 2023

@IAlibay I'm on mobile, but I was trying to look into why one of the action failed. Was that expected?

@IAlibay
Copy link
Member Author

IAlibay commented Dec 23, 2023

👀 An action failed? How odd it looked green on my end - let me check.

@IAlibay
Copy link
Member Author

IAlibay commented Dec 23, 2023

I'm not sure what happened @RMeli - sorry I might have missed something on my end. If merge CI returns green I'm going to say it's probably fine? (we only touched GH actions here anyways) https://github.com/MDAnalysis/mdanalysis/actions/runs/7309090802

@IAlibay
Copy link
Member Author

IAlibay commented Dec 23, 2023

Looks like it all went green, should be good to go :)

@RMeli
Copy link
Member

RMeli commented Dec 23, 2023

Yes, I can confirm all green on develop, so all good.

ljwoods2 pushed a commit to ljwoods2/mdanalysis that referenced this pull request Dec 29, 2023
Running full deps py3.12 check in github actions now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants