-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README to reflect move to GitHub Discussions #4375
Conversation
Remove mailing list badges and update links.
Linter Bot Results:Hi @RMeli! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4375 +/- ##
==========================================
Coverage 93.41% 93.41%
==========================================
Files 171 185 +14
Lines 22511 23625 +1114
Branches 4129 4129
==========================================
+ Hits 21028 22069 +1041
- Misses 963 1036 +73
Partials 520 520 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. Maybe generate a banner with shield.io for GH Discussions in their place?
Please check other places such as https://github.com/MDAnalysis/mdanalysis/blob/develop/package/pyproject.toml (and setup.py?) ... I'd git grep
the whole source tree.
Thanks for the update... sorry for brevity.
@orbeckst, very good point. I didn't look past the readme. I now added the shield and removed all occurrences. I also toned down the "question" issue template, since it would be trivial now to migrate an issue to a discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the thorough scouring of the docs — there were more places than I thought. LGTM
Other places:
- Could you please also look at the UG? I assume we have similar occurrences there.
- Did you change the website?
- Teaching materials? — These can probably be updated as we go along.
- MDAKits??
@RMeli please squash-merge when you're happy with it. |
Yes, I'll look at the other places in the coming days, thanks for bringing this up! |
📚 Documentation preview 📚: https://mdanalysis--4375.org.readthedocs.build/en/4375/