Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the target build names for cibuildwheels for cirrus #4392

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Dec 26, 2023

Fixes #4391

We're deviating from scipy here, so I'm not 100% sure, but we'll have to try it out in practice and see what happens.

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4392.org.readthedocs.build/en/4392/

@IAlibay
Copy link
Member Author

IAlibay commented Dec 26, 2023

@fiona-naughton we'll need to merge here and check what happens when we push tags.

Copy link
Contributor

@fiona-naughton fiona-naughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - fingers crossed!

Copy link

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df720ba) 93.41% compared to head (18aad52) 93.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4392     +/-   ##
==========================================
  Coverage    93.41%   93.41%             
==========================================
  Files          171      185     +14     
  Lines        22511    23625   +1114     
  Branches      4129     4129             
==========================================
+ Hits         21028    22069   +1041     
- Misses         963     1036     +73     
  Partials       520      520             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay merged commit 5bf1979 into develop Dec 26, 2023
26 checks passed
@IAlibay IAlibay deleted the fix-cibw branch December 26, 2023 19:40
ljwoods2 pushed a commit to ljwoods2/mdanalysis that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cirrus deployment is broken [release 2.7.0]
2 participants