-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate PSA and replace with PathSimAnalysis mdakit #4403
Conversation
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4403 +/- ##
===========================================
- Coverage 93.41% 93.35% -0.06%
===========================================
Files 171 185 +14
Lines 22511 23117 +606
Branches 4129 4040 -89
===========================================
+ Hits 21028 21582 +554
- Misses 963 1039 +76
+ Partials 520 496 -24 ☔ View full report in Codecov by Sentry. |
Discussion points:
|
Ok this is good to go - discussion from last week's call was that we would remove docs & tests and just intersphinx to the kits. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the decisions & looks fine to me.
Docs show the deprecation and link to PSA kit ✅
Thanks @orbeckst ! |
Towards #4308
Changes made in this Pull Request:
TODO:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4403.org.readthedocs.build/en/4403/