Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used between to update donors_sel and acceptors_sel #4422

Closed
wants to merge 3 commits into from
Closed

Used between to update donors_sel and acceptors_sel #4422

wants to merge 3 commits into from

Conversation

Sumit112192
Copy link
Contributor

@Sumit112192 Sumit112192 commented Jan 11, 2024

Fixes #4130

Changes made in this Pull Request:

  • I used the between keyword to update the self.donors_sel and self.acceptors_sel keywords to reduce the search space for the capped_distance function.
  • I want to know if my logic is correct so that I can think more in that direction.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developer certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4422.org.readthedocs.build/en/4422/

Copy link

github-actions bot commented Jan 11, 2024

Linter Bot Results:

Hi @Sumit112192! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (846131c) 93.36% compared to head (8eac74a) 93.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4422     +/-   ##
==========================================
  Coverage    93.36%   93.36%             
==========================================
  Files          171      185     +14     
  Lines        21736    22853   +1117     
  Branches      4012     4012             
==========================================
+ Hits         20293    21337   +1044     
- Misses         954     1027     +73     
  Partials       489      489             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sumit112192
Copy link
Contributor Author

Sumit112192 commented Jan 12, 2024

In the hydrogen bond analysis, if the user passed donor_sel, it might cause a pair of results where both hydrogen and donor have the same index, essentially the same hydrogen atom, since we were not putting any min_cutoff constraint in the capped_distance function of _get_dh_pairs() function

@Sumit112192
Copy link
Contributor Author

Can someone guide me if I am going in the right direction here?

@orbeckst
Copy link
Member

@richardjgowers could you please shepherd this PR? You're the one who originally made the performance improvement suggestion in #4130. Thanks!

@Sumit112192 Sumit112192 closed this by deleting the head repository Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

potential performance improvements for H-bond analysis 'between'
3 participants